-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flow graph initial iteration #14091
Flow graph initial iteration #14091
Conversation
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
…j/Babylon.js into flow-graph-iteration-0_1
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://babylonsnapshots.z22.web.core.windows.net/refs/pull/14091/merge/index.html#WGZLGJ#4600 Links to test babylon tools with this snapshot: https://playground.babylonjs.com/?snapshot=refs/pull/14091/merge To test the snapshot in the playground with a playground ID add it after the snapshot query string: https://playground.babylonjs.com/?snapshot=refs/pull/14091/merge#BCU1XR#0 |
Before submitting my review - this PR is missing code doc (ts doc for functions/classes), which would help provide scope to each component |
Visualization tests for webgl1 have failed. If some tests failed because the snapshots do not match, the report can be found at If tests were successful afterwards, this report might not be available anymore. |
Visualization tests for webgl2 have failed. If some tests failed because the snapshots do not match, the report can be found at If tests were successful afterwards, this report might not be available anymore. |
packages/dev/core/src/FlowGraph/Blocks/Data/flowGraphAddBlock.ts
Outdated
Show resolved
Hide resolved
packages/dev/core/src/FlowGraph/Blocks/Data/flowGraphAddBlock.ts
Outdated
Show resolved
Hide resolved
packages/dev/core/src/FlowGraph/Blocks/Event/flowGraphMeshPickEventBlock.ts
Outdated
Show resolved
Hide resolved
packages/dev/core/src/FlowGraph/Blocks/Event/flowGraphMeshPickEventBlock.ts
Outdated
Show resolved
Hide resolved
packages/dev/core/src/FlowGraph/Blocks/Execution/flowGraphForLoopBlock.ts
Outdated
Show resolved
Hide resolved
packages/dev/core/src/FlowGraph/Blocks/Execution/flowGraphForLoopBlock.ts
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
General comment - dispose should be implemented wherever it makes sense (removing observers, removing event listeners (if used) etc'.
packages/dev/core/src/FlowGraph/Blocks/Event/flowGraphMeshPickEventBlock.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The framework seems quite easy to use!
I think we need some examples to better understand how it all fits together.
packages/dev/core/src/FlowGraph/Blocks/Data/flowGraphAddBlock.ts
Outdated
Show resolved
Hide resolved
packages/dev/core/src/FlowGraph/Blocks/Event/flowGraphMeshPickEventBlock.ts
Outdated
Show resolved
Hide resolved
packages/dev/core/src/FlowGraph/Blocks/Event/flowGraphMeshPickEventBlock.ts
Outdated
Show resolved
Hide resolved
packages/dev/core/src/FlowGraph/Blocks/Event/flowGraphMeshPickEventBlock.ts
Outdated
Show resolved
Hide resolved
packages/dev/core/src/FlowGraph/Blocks/Execution/flowGraphForLoopBlock.ts
Outdated
Show resolved
Hide resolved
packages/dev/core/src/FlowGraph/Blocks/Data/flowGraphAddBlock.ts
Outdated
Show resolved
Hide resolved
packages/dev/core/src/FlowGraph/Blocks/Event/flowGraphMeshPickEventBlock.ts
Outdated
Show resolved
Hide resolved
packages/dev/core/src/FlowGraph/Blocks/Data/flowGraphAddBlock.ts
Outdated
Show resolved
Hide resolved
packages/dev/core/src/FlowGraph/Blocks/Data/flowGraphAddBlock.ts
Outdated
Show resolved
Hide resolved
packages/dev/core/src/FlowGraph/Blocks/Execution/flowGraphForLoopBlock.ts
Outdated
Show resolved
Hide resolved
packages/dev/core/src/FlowGraph/Blocks/Data/flowGraphBinaryOpBlocks.ts
Outdated
Show resolved
Hide resolved
34ae681
to
a6af0ae
Compare
packages/dev/core/src/FlowGraph/Blocks/Data/flowGraphBinaryOpBlocks.ts
Outdated
Show resolved
Hide resolved
packages/dev/core/src/FlowGraph/Blocks/Event/flowGraphMeshPickEventBlock.ts
Outdated
Show resolved
Hide resolved
packages/dev/core/src/FlowGraph/Blocks/Event/flowGraphMeshPickEventBlock.ts
Outdated
Show resolved
Hide resolved
fdc65cf
to
532bd30
Compare
packages/dev/core/src/FlowGraph/Blocks/Event/flowGraphMeshPickEventBlock.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a small comment :-)
@Popov72 - just waiting for your final approval |
This is the initial work for an engine that will support a paradigm of creating chains of actions that trigger in response to events (a "flow graph"). Please note it is still experimental and subject to many changes until its final iteration.
Example PG: #P0U4WL#2 (Click on the mesh and it will run a for loop from 0 to 10 (exclusive) and print its index + 1)
#P0U4WL#1 (Click on the mesh and it will print its name)
EDIT: updated the example PG with the most recent syntax