Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flow graph initial iteration #14091

Merged
merged 30 commits into from
Aug 9, 2023

Conversation

carolhmj
Copy link
Contributor

@carolhmj carolhmj commented Jul 27, 2023

This is the initial work for an engine that will support a paradigm of creating chains of actions that trigger in response to events (a "flow graph"). Please note it is still experimental and subject to many changes until its final iteration.

Example PG: #P0U4WL#2 (Click on the mesh and it will run a for loop from 0 to 10 (exclusive) and print its index + 1)
#P0U4WL#1 (Click on the mesh and it will print its name)

EDIT: updated the example PG with the most recent syntax

@carolhmj carolhmj marked this pull request as draft July 27, 2023 17:13
@bjsplat
Copy link
Collaborator

bjsplat commented Jul 27, 2023

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Jul 27, 2023

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Jul 27, 2023

@RaananW
Copy link
Member

RaananW commented Jul 31, 2023

Before submitting my review - this PR is missing code doc (ts doc for functions/classes), which would help provide scope to each component

@bjsplat
Copy link
Collaborator

bjsplat commented Jul 31, 2023

Visualization tests for webgl1 have failed. If some tests failed because the snapshots do not match, the report can be found at

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/14091/merge/testResults/webgl1/index.html

If tests were successful afterwards, this report might not be available anymore.

@bjsplat
Copy link
Collaborator

bjsplat commented Jul 31, 2023

Visualization tests for webgl2 have failed. If some tests failed because the snapshots do not match, the report can be found at

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/14091/merge/testResults/webgl2/index.html

If tests were successful afterwards, this report might not be available anymore.

Copy link
Member

@RaananW RaananW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General comment - dispose should be implemented wherever it makes sense (removing observers, removing event listeners (if used) etc'.

packages/dev/core/src/FlowGraph/flowGraphEventBlock.ts Outdated Show resolved Hide resolved
packages/dev/core/src/FlowGraph/flowGraphEventBlock.ts Outdated Show resolved Hide resolved
packages/dev/core/src/FlowGraph/flowGraphEventBlock.ts Outdated Show resolved Hide resolved
packages/dev/core/src/FlowGraph/iDataUpdater.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@Popov72 Popov72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The framework seems quite easy to use!

I think we need some examples to better understand how it all fits together.

packages/dev/core/src/FlowGraph/flowGraphEventBlock.ts Outdated Show resolved Hide resolved
packages/dev/core/src/FlowGraph/flowGraphEventBlock.ts Outdated Show resolved Hide resolved
packages/dev/core/src/FlowGraph/flowGraphExecutionBlock.ts Outdated Show resolved Hide resolved
packages/dev/core/src/FlowGraph/iDataUpdater.ts Outdated Show resolved Hide resolved
packages/dev/core/src/FlowGraph/iDataUpdater.ts Outdated Show resolved Hide resolved
@RaananW RaananW changed the title [Draft] Flow graph initial iteration Flow graph initial iteration Aug 7, 2023
@carolhmj carolhmj requested a review from Popov72 August 9, 2023 12:19
Copy link
Member

@RaananW RaananW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a small comment :-)

packages/dev/core/src/FlowGraph/flowGraphConnection.ts Outdated Show resolved Hide resolved
@RaananW
Copy link
Member

RaananW commented Aug 9, 2023

@Popov72 - just waiting for your final approval

@RaananW RaananW enabled auto-merge August 9, 2023 16:46
@RaananW RaananW merged commit 866678d into BabylonJS:master Aug 9, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants