Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add observable for collision finished events/trigger events #14109

Merged
merged 7 commits into from
Aug 7, 2023

Conversation

carolhmj
Copy link
Contributor

@carolhmj carolhmj commented Aug 1, 2023

Test PG: #Z8HTUN#613 (collision ended)
#M0C2X5 (triggers)

@bjsplat
Copy link
Collaborator

bjsplat commented Aug 1, 2023

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Aug 1, 2023

Copy link
Member

@RaananW RaananW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does it mean we need to wait with merging this?

@carolhmj
Copy link
Contributor Author

carolhmj commented Aug 3, 2023

does it mean we need to wait with merging this?

Can be merged now 😄

EDIT: oop give me a sec
EDIT2: all good now :)

@carolhmj carolhmj marked this pull request as draft August 4, 2023 12:06
@bjsplat
Copy link
Collaborator

bjsplat commented Aug 4, 2023

Visualization tests for webgl2 have failed. If some tests failed because the snapshots do not match, the report can be found at

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/14109/merge/testResults/webgl2/index.html

If tests were successful afterwards, this report might not be available anymore.

@carolhmj carolhmj changed the title Add observable for collision finished events Add observable for collision finished events/trigger events Aug 4, 2023
@carolhmj carolhmj marked this pull request as ready for review August 4, 2023 13:13
@bjsplat
Copy link
Collaborator

bjsplat commented Aug 4, 2023

Visualization tests for webgl2 have failed. If some tests failed because the snapshots do not match, the report can be found at

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/14109/merge/testResults/webgl2/index.html

If tests were successful afterwards, this report might not be available anymore.

@RaananW
Copy link
Member

RaananW commented Aug 7, 2023

@CedricGuillemet - any issues merging this?

@CedricGuillemet
Copy link
Contributor

All good!

@RaananW RaananW enabled auto-merge August 7, 2023 09:36
@bjsplat
Copy link
Collaborator

bjsplat commented Aug 7, 2023

Visualization tests for webgl2 have failed. If some tests failed because the snapshots do not match, the report can be found at

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/14109/merge/testResults/webgl2/index.html

If tests were successful afterwards, this report might not be available anymore.

@RaananW RaananW merged commit d967047 into BabylonJS:master Aug 7, 2023
9 checks passed
@carolhmj carolhmj mentioned this pull request Aug 7, 2023
@carolhmj carolhmj deleted the exposeCollisionEventType branch August 28, 2023 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants