Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebDeviceInputSystem: Add additional checks for pointermove started Touch events #14174

Merged
merged 1 commit into from
Aug 17, 2023

Conversation

PolygonalSun
Copy link
Contributor

A user in the forum found a particular edge case where pointermove events were inconsistently interacting with a scene where pointer capture was being programmatically set. Because this worked with 4.2.x, this behavior was seen as a regression. This PR adds some additional checks to the touch code to more properly handle this scenario.

Forum Link: https://forum.babylonjs.com/t/pointer-capture-failing-for-babylon-pointer-observable-during-a-scroll-event/43253/7

@bjsplat
Copy link
Collaborator

bjsplat commented Aug 16, 2023

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Aug 16, 2023

@PolygonalSun PolygonalSun marked this pull request as ready for review August 16, 2023 22:16
@PolygonalSun PolygonalSun merged commit cbe4dc7 into BabylonJS:master Aug 17, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants