Fix mute button getting stuck on iOS #14178
Conversation
On iOS, if `AudioEngine.unlock()` is called from any other event handler than a `click` event handler, then the promise returned by `audioContext.resume` never resolves and the audio engine `_tryToRun` flag never gets set back to `false`. This causes all subsequent calls to `AudioEngine._triggerRunningState()` to early out making it impossible to resume the audio context again. This change fixes the issue by checking the `_tryToRun` flag. If it is `true` then the audio context is suspended and the `_tryToRun` flag is reset to `false` before attempting to resume the audio context.
|
Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://babylonsnapshots.z22.web.core.windows.net/refs/pull/14178/merge/index.html#WGZLGJ#4600 Links to test babylon tools with this snapshot: https://playground.babylonjs.com/?snapshot=refs/pull/14178/merge To test the snapshot in the playground with a playground ID add it after the snapshot query string: https://playground.babylonjs.com/?snapshot=refs/pull/14178/merge#BCU1XR#0 |
On iOS, if
AudioEngine.unlock()is called from any other event handler than aclickevent handler, then the promise returned byaudioContext.resumenever resolves and the audio engine_tryToRunflag never gets set back tofalse. This causes all subsequent calls toAudioEngine._triggerRunningState()to early out making it impossible to resume the audio context again.This change fixes the issue by checking the
_tryToRunflag. If it istruethen the audio context is suspended and the_tryToRunflag is reset tofalsebefore attempting to resume the audio context.Reported on forum: https://forum.babylonjs.com/t/unmute-icon-remove/257/25
Tested on iOS using playground https://playground.babylonjs.com/#35VF39#3