Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Particle Systems: Fix the pivot position for rotations #14186

Merged
merged 1 commit into from
Aug 21, 2023

Conversation

Popov72
Copy link
Contributor

@Popov72 Popov72 commented Aug 21, 2023

The fix applies the rotation before the pivot is added back, whereas the current code add the pivot back before applying the rotation.

Test PG: https://playground.babylonjs.com/#0K3AQ2#2628

@bjsplat
Copy link
Collaborator

bjsplat commented Aug 21, 2023

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Aug 21, 2023

@sebavan sebavan merged commit 1caea2e into BabylonJS:master Aug 21, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants