Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GRL - camera facing #14191

Merged
merged 44 commits into from
Oct 18, 2023
Merged

GRL - camera facing #14191

merged 44 commits into from
Oct 18, 2023

Conversation

RolandCsibrei
Copy link
Contributor

@RolandCsibrei RolandCsibrei commented Aug 22, 2023

TODOs:

  • Create base mesh class for camera facing and non camera facing greased line meshes
  • Widths in instance modes
  • Calculate correct UVs for non camera facing meshes
  • Do not join ribbon paths in path_mode
  • Set default values for the options, same as for the camera facing GRL
  • Calculate slopes faster
  • Widths in instance mode and different point modes
  • Color tables in instance mode and different point modes
  • Clone
  • Serialize
  • Parse
  • Doublesided
  • Closed paths
  • Lazy mode
  • Check UVs
  • Offsets
  • Add face modes in options (single, doublesided, single no culling). Remove doubleSided option.
  • Check color pointers / move to base mesh
  • Share color textures
  • Calculate directions in points mode points if no direction is specified. Don't use default direction. Add auto calc modes.
  • Visualization tests

OPTIMALIZATIONS:

  • Don't use ribbon builder class for building the mesh but create it manually in a more optimal way

@bjsplat
Copy link
Collaborator

bjsplat commented Aug 22, 2023

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Aug 22, 2023

@bjsplat
Copy link
Collaborator

bjsplat commented Aug 31, 2023

Visualization tests for webgl1 have failed. If some tests failed because the snapshots do not match, the report can be found at

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/14191/merge/testResults/webgl1/index.html

If tests were successful afterwards, this report might not be available anymore.

@bjsplat
Copy link
Collaborator

bjsplat commented Aug 31, 2023

Visualization tests for webgl2 have failed. If some tests failed because the snapshots do not match, the report can be found at

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/14191/merge/testResults/webgl2/index.html

If tests were successful afterwards, this report might not be available anymore.

@RolandCsibrei RolandCsibrei marked this pull request as ready for review October 6, 2023 05:26
Popov72

This comment was marked as duplicate.

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 14, 2023

Visualization tests for webgl1 have failed. If some tests failed because the snapshots do not match, the report can be found at

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/14191/merge/testResults/webgl1/index.html

If tests were successful afterwards, this report might not be available anymore.

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 14, 2023

Visualization tests for webgl2 have failed. If some tests failed because the snapshots do not match, the report can be found at

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/14191/merge/testResults/webgl2/index.html

If tests were successful afterwards, this report might not be available anymore.

@RolandCsibrei
Copy link
Contributor Author

@Popov72 Hi! Ready for re-review. Thank you!

Copy link
Contributor

@Popov72 Popov72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there!

@RolandCsibrei
Copy link
Contributor Author

@Popov72 I've modified the MeshesToLines tool function's predicate and added a new one while waiting for @sebavan

@sebavan sebavan merged commit 745d094 into BabylonJS:master Oct 18, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants