ArcRotateCamera: Modify offset math to correctly zoom to point #14209
Conversation
|
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
|
Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://babylonsnapshots.z22.web.core.windows.net/refs/pull/14209/merge/index.html#WGZLGJ#4600 Links to test babylon tools with this snapshot: https://playground.babylonjs.com/?snapshot=refs/pull/14209/merge To test the snapshot in the playground with a playground ID add it after the snapshot query string: https://playground.babylonjs.com/?snapshot=refs/pull/14209/merge#BCU1XR#0 |
packages/dev/core/src/Cameras/Inputs/arcRotateCameraMouseWheelInput.ts
Outdated
Show resolved
Hide resolved
packages/dev/core/src/Cameras/Inputs/arcRotateCameraMouseWheelInput.ts
Outdated
Show resolved
Hide resolved
packages/dev/core/src/Cameras/Inputs/arcRotateCameraMouseWheelInput.ts
Outdated
Show resolved
Hide resolved
|
Visualization tests for webgl1 have failed. If some tests failed because the snapshots do not match, the report can be found at If tests were successful afterwards, this report might not be available anymore. |
|
Visualization tests for webgl2 have failed. If some tests failed because the snapshots do not match, the report can be found at If tests were successful afterwards, this report might not be available anymore. |
1 similar comment
|
Visualization tests for webgl2 have failed. If some tests failed because the snapshots do not match, the report can be found at If tests were successful afterwards, this report might not be available anymore. |
|
Visualization tests for webgl1 have failed. If some tests failed because the snapshots do not match, the report can be found at If tests were successful afterwards, this report might not be available anymore. |
packages/dev/core/src/Cameras/Inputs/arcRotateCameraMouseWheelInput.ts
Outdated
Show resolved
Hide resolved
There was a previous fix that updated the ArcRotateCamera to factor in a
targetScreenOffsetto zooming to a specific point. Unfortunately, there was an issue with how it was modifying the ray origin used to determine zoom destination. This PR changes the math up to properly convert the screen offset to world space so that the zoom origin is calculated correctly.