Fixes Bounty #Generate equirectangular 360 panorama from babylon.js scene

[lokiiarora]

Hey, I'm a first-time contributor to Babylon.js, love the community, and would love it if someone could review this PR.
This PR is based on @Pryme8 's work on this playground here.

[bjsplat]

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

[bjsplat]

Snapshot stored with reference name:
refs/pull/14251/merge

Test environment:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/14251/merge/index.html

To test a playground add it to the URL, for example:

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/14251/merge/index.html#WGZLGJ#4600

Links to test babylon tools with this snapshot:

https://playground.babylonjs.com/?snapshot=refs/pull/14251/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/14251/merge
https://gui.babylonjs.com/?snapshot=refs/pull/14251/merge
https://nme.babylonjs.com/?snapshot=refs/pull/14251/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/14251/merge#BCU1XR#0

[RaananW]

That's really great! thank you so much for that :-)

Got a question. I tried it, and it works great. The only thing I noticed - the image generated is flipped:

https://playground.babylonjs.com/?snapshot=refs/pull/14251/merge#Z6SWJU#5

results in:

Was that intentional?

[lokiiarora]

That's really great! thank you so much for that :-)

Got a question. I tried it, and it works great. The only thing I noticed - the image generated is flipped:

https://playground.babylonjs.com/?snapshot=refs/pull/14251/merge#Z6SWJU#5

results in:

Was that intentional?

Ouch, this was not intentional, I guess I'm not passing invertY flag, let me just do it

[lokiiarora]

@RaananW fixed on local, will verify on remote :)

[lokiiarora]

looks fine now @RaananW

[RaananW]

LGTM! just a note about the shader code itself. I'll also wait for others to comment, but I will approve right after the shader code moves.

[carolhmj]

LGTM 😸

[sebavan]

Aside of naming, this looks great to me !!!

[sebavan]

Could you allow an option to pass the probe in ?

[lokiiarora]

Could you allow an option to pass the probe in ?

has been added, do check if this is how you would want it to be?

[sebavan]

Nice, looks great !!!!

[evidanary]

@RaananW and @lokiiarora looks like the feature does not work for post processing. We've tested it for a scene that uses the DefaultRenderingPipeline with tonemapping enabled. I've tested it on my end and can confirm the tone mapping does not get applied when generating the equirectangular image. Is this a limitation/bug of this feature or does the underlying reflectionprobes support post-processing?

[sebavan]

I do not think it is supported at the moment. It would be great if you could create a topic in the forum with a repro in the playground. This way we could simply check how hard this could be to support.