Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve perf of noise texture gen in lens and ssao #14300

Merged
merged 5 commits into from
Sep 13, 2023
Merged

Improve perf of noise texture gen in lens and ssao #14300

merged 5 commits into from
Sep 13, 2023

Conversation

bghgary
Copy link
Contributor

@bghgary bghgary commented Sep 13, 2023

Use raw texture with a buffer of pixels instead of dynamic texture to render one pixel at a time using canvas.

@bjsplat
Copy link
Collaborator

bjsplat commented Sep 13, 2023

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Sep 13, 2023

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

sebavan
sebavan approved these changes Sep 13, 2023
View reviewed changes
Copy link
Member

@sebavan sebavan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THANKS A TON !!! :-)

Aside of core -> core -> ../../../ a bit all over it looks all good.

packages/dev/core/src/PostProcesses/RenderPipeline/Pipelines/lensRenderingPipeline.ts Outdated Show resolved Hide resolved
packages/dev/core/src/PostProcesses/RenderPipeline/Pipelines/lensRenderingPipeline.ts Outdated Show resolved Hide resolved
@bjsplat
Copy link
Collaborator

bjsplat commented Sep 13, 2023

Snapshot stored with reference name:
refs/pull/14300/merge

Test environment:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/14300/merge/index.html

To test a playground add it to the URL, for example:

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/14300/merge/index.html#WGZLGJ#4600

Links to test babylon tools with this snapshot:

https://playground.babylonjs.com/?snapshot=refs/pull/14300/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/14300/merge
https://gui.babylonjs.com/?snapshot=refs/pull/14300/merge
https://nme.babylonjs.com/?snapshot=refs/pull/14300/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/14300/merge#BCU1XR#0

@bghgary bghgary marked this pull request as ready for review September 13, 2023 17:55
@bghgary bghgary merged commit 67540ef into BabylonJS:master Sep 13, 2023
10 checks passed
@bghgary bghgary deleted the gen-texture-perf branch September 13, 2023 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Popov72 Popov72 Popov72 approved these changes

@sebavan sebavan sebavan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bghgary @bjsplat @Popov72 @sebavan