Add an ugly flag to glTF draco loader extension #14325
Conversation
|
I need to figure out how to create files like this. Once that happens, I'll add a visual test in a separate PR. |
|
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
|
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
|
Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://babylonsnapshots.z22.web.core.windows.net/refs/pull/14325/merge/index.html#WGZLGJ#4600 Links to test babylon tools with this snapshot: https://playground.babylonjs.com/?snapshot=refs/pull/14325/merge To test the snapshot in the playground with a playground ID add it after the snapshot query string: https://playground.babylonjs.com/?snapshot=refs/pull/14325/merge#BCU1XR#0 |
|
Visualization tests for webgl1 have failed. If some tests failed because the snapshots do not match, the report can be found at If tests were successful afterwards, this report might not be available anymore. |
|
Visualization tests for webgl2 have failed. If some tests failed because the snapshots do not match, the report can be found at If tests were successful afterwards, this report might not be available anymore. |
There appears to be lots of files out there with invalid Draco data where the
normalizedflag in the data is markedfalsewhen it should betrue. The glTF accessor info is correct. Draco data is supposed to be self-contained, so this is troubling. For now, adding this flag to read from the glTF accessor instead and log a warning when there is a mismatch.