Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebGPU: Add labels to buffers + support non float vertex buffers #14397

Merged
merged 5 commits into from Oct 6, 2023

Conversation

Popov72
Copy link
Contributor

@Popov72 Popov72 commented Oct 5, 2023

There are several updates in this PR:

  • add labels to buffers to help debugging
  • add support for non float buffers for the standard vertex buffer types (position, normal, uv, etc)
  • fix a bug in Geometry.setVerticesBuffer when computing the number of vertices when the type is UNSIGNED_BYTE
  • re-enable the "GLTF Buggy with Meshopt Compression" visualization test, now that non float vertex buffers are supported

After the PR is merged, these PGs, which are using non float vertex buffers for position/normal/uv, will work:

Regarding TintWASM, I did not include the latest package in the PR because it went from 1.6Mb to 2.6Mb...

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 5, 2023

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 5, 2023

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 5, 2023

packages/dev/core/src/Buffers/buffer.ts Outdated Show resolved Hide resolved
packages/dev/core/src/Meshes/geometry.ts Outdated Show resolved Hide resolved
@sebavan sebavan enabled auto-merge October 5, 2023 19:34
@sebavan sebavan merged commit ae1e04b into BabylonJS:master Oct 6, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants