Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a legacy issue with older ts versions #14421

Merged
merged 2 commits into from
Oct 12, 2023

Conversation

RaananW
Copy link
Member

@RaananW RaananW commented Oct 12, 2023

type in an import is 100% correct, but fails if used with an older version of typescript.

The thinEngine change is just for consistency.

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 12, 2023

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@RaananW RaananW enabled auto-merge (squash) October 12, 2023 15:25
@bjsplat
Copy link
Collaborator

bjsplat commented Oct 12, 2023

@RaananW RaananW merged commit 69b8530 into BabylonJS:master Oct 12, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants