-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Faster twin renderer #14441
Faster twin renderer #14441
Conversation
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://babylonsnapshots.z22.web.core.windows.net/refs/pull/14441/merge/index.html#WGZLGJ#4600 Links to test babylon tools with this snapshot: https://playground.babylonjs.com/?snapshot=refs/pull/14441/merge To test the snapshot in the playground with a playground ID add it after the snapshot query string: https://playground.babylonjs.com/?snapshot=refs/pull/14441/merge#BCU1XR#0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's discuss this offline :-)
packages/tools/accessibility/src/HtmlTwin/htmlTwinItemAdapter.tsx
Outdated
Show resolved
Hide resolved
packages/tools/accessibility/src/HtmlTwin/htmlTwinItemAdapter.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly missing doc!
Generally speaking, there are a lot of checks with "instanceof", which is slow in javascript. If they're not in the hot path, then that's fine, otherwise I think you should try replacing them with something else (when possible), because as I understand it, this PR is intended to improve overall performance?
This PR is a rearchitecture of the HTMLTwinRenderer, aiming to improve its speed.
Some PGs I tested with:
The ones in: https://doc.babylonjs.com/toolsAndResources/accessibility/screenReaders
Stress test: #C9GZTF#43
AddAllControls: #C9GZTF#49
Weapons demo with accessibility: #I6V1ST#240