Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: change the way arrays are literals #14503

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

GuoBinyong
Copy link
Contributor

change the way arrays are literals

Changed all the way in which arrays were created by constructors to array literals throughout the project, because array literals are more performant.

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 9, 2023

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 9, 2023

@RaananW
Copy link
Member

RaananW commented Nov 9, 2023

are more performant

when generated. afterwards (i.e. accessing objects) it is technically the same

@RaananW RaananW merged commit 5d3e771 into BabylonJS:master Nov 9, 2023
10 checks passed
@GuoBinyong
Copy link
Contributor Author

What do you mean

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants