Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GeometryBufferRenderer: Use bone texture if supported #14548

Merged
merged 1 commit into from Nov 27, 2023

Conversation

Popov72
Copy link
Contributor

@Popov72 Popov72 commented Nov 27, 2023

See https://forum.babylonjs.com/t/error-on-new-ssrrenderingpipeline/41812/16

We used uniforms even when bone texture was supported because of the velocity target (which only supports passing previous bone data through uniforms). The PR let use bone texture for the model while still using uniforms for previous bone data.

PG to test: https://playground.babylonjs.com/#E5YGEL#59

You can see with Spector that with the current code, the bone matrices are passed through uniforms, whereas the shader uses the bone texture when the PR is applied.

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 27, 2023

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 27, 2023

@sebavan sebavan merged commit a9bd265 into BabylonJS:master Nov 27, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants