Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect range check when reading glTF buffer #14557

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

bghgary
Copy link
Contributor

@bghgary bghgary commented Nov 29, 2023

This is a follow up to #14540 which still has an incorrect range check. The intention of the readViewAsync checks is to make sure the arguments fit within the given array buffer view.

I've tested against the PG from the forum issue to make sure it still works.

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 29, 2023

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 29, 2023

@sebavan sebavan merged commit 6338f09 into BabylonJS:master Nov 29, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants