Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix camera rotation when exporting glTF #14562

Merged
merged 3 commits into from Nov 30, 2023

Conversation

bghgary
Copy link
Contributor

@bghgary bghgary commented Nov 29, 2023

See https://forum.babylonjs.com/t/gltfexport-flipped-camera/45986.

Introduced partially by #13909 but it was already somewhat broken.

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 29, 2023

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 29, 2023

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bghgary bghgary marked this pull request as ready for review November 29, 2023 22:27
@bghgary bghgary enabled auto-merge (squash) November 29, 2023 22:36
@bjsplat
Copy link
Collaborator

bjsplat commented Nov 29, 2023

@bghgary bghgary marked this pull request as draft November 29, 2023 22:58
auto-merge was automatically disabled November 29, 2023 22:58

Pull request was converted to draft

@bghgary bghgary marked this pull request as ready for review November 30, 2023 00:36
@RaananW RaananW merged commit 41bbdbb into BabylonJS:master Nov 30, 2023
10 checks passed
@bghgary bghgary deleted the gltf-camera-export-fix branch November 30, 2023 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants