Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parent group entities to object entities on the OBJ loader #14565

Merged
merged 2 commits into from Nov 30, 2023

Conversation

carolhmj
Copy link
Contributor

Related forum issue: https://forum.babylonjs.com/t/obj-export-to-babylon-nodes-are-doubled/46028
The cause for the apparent doubling of nodes was having an "o" entity followed by a "g" entity:
image
In our loader, encountering both of these definitions results in creating a new mesh. However, groups are parts of objects, so we should be parenting the group to the object to make that relationship explicit.

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 30, 2023

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 30, 2023

Copy link
Member

@RaananW RaananW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the logging - LGTM. approved, make sure to resolve the logging comment before merging.

@sebavan sebavan merged commit 7d2c9ee into BabylonJS:master Nov 30, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants