Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PBR custom materials: Fix default shader name #14576

Merged
merged 1 commit into from Dec 4, 2023
Merged

Conversation

Popov72
Copy link
Contributor

@Popov72 Popov72 commented Dec 3, 2023

See https://forum.babylonjs.com/t/compute-shaders-ocean-demo-is-not-working/46139

There was a name collision with the CustomMaterial, which also uses "custom_" as the prefix name.

@bjsplat
Copy link
Collaborator

bjsplat commented Dec 3, 2023

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Dec 3, 2023

@sebavan sebavan merged commit d01337f into master Dec 4, 2023
10 checks passed
@sebavan sebavan deleted the Popov72-patch-2 branch December 4, 2023 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants