PBRCustomMaterial & CustomMaterial support MaterialPlugin #14593
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PBRCustomMaterial
is a subclass ofPBRMaterial
, but does not support MaterialPlugin.In the implementation of PBRCustomMaterial, the shader injection point is removed , causing material plugin to be unable to inject custom code.
CustomMaterial
has the same problem.This playground https://www.babylonjs-playground.com/#VNLCRN can reproduce the issue.
In the playground, PBRCustomMaterial using MeshDebugPluginMaterial, does not rendering wireframe.
The playgroud rendering result is as follows
red mesh use
PBRCustomMaterial
, green mesh usePBRMaterial
yellow mesh use
CustomMaterial
, blue mesh useStandardMaterial
I hope to fix the problem by this commit.
In the commit,
PBRCustomMaterial
andCustomMaterial
After fixing this issue, the above plaground rendering result is as follows