Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Light: Add helper methods to retrieve view and projection matrices #14598

Merged
merged 1 commit into from
Dec 11, 2023

Conversation

Popov72
Copy link
Contributor

@Popov72 Popov72 commented Dec 9, 2023

No description provided.

@bjsplat
Copy link
Collaborator

bjsplat commented Dec 9, 2023

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Dec 9, 2023

@Popov72
Copy link
Contributor Author

Popov72 commented Dec 9, 2023

The CI is failing with:

1 leak(s) found @ #T90MQ4#14

This is a test that draws lines, so there's no reason for my PR to affect it (anyway, the PR only adds two little helper methods, so it shouldn't impact anything).

@RaananW
Copy link
Member

RaananW commented Dec 11, 2023

The CI is failing with:

1 leak(s) found @ #T90MQ4#14

This is a test that draws lines, so there's no reason for my PR to affect it (anyway, the PR only adds two little helper methods, so it shouldn't impact anything).

checking why this test is flaky. I am running it again.

@RaananW RaananW merged commit d50849f into BabylonJS:master Dec 11, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants