-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add observers to WebXRCamera when a rotation is performed #14660
Add observers to WebXRCamera when a rotation is performed #14660
Conversation
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://babylonsnapshots.z22.web.core.windows.net/refs/pull/14660/merge/index.html#WGZLGJ#4600 Links to test babylon tools with this snapshot: https://playground.babylonjs.com/?snapshot=refs/pull/14660/merge To test the snapshot in the playground with a playground ID add it after the snapshot query string: https://playground.babylonjs.com/?snapshot=refs/pull/14660/merge#BCU1XR#0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made the mistake of putting the first observable on the camera and not on the feature itself. There is no reason for it to be on the camera. Let's learn from (my) mistakes and move the observables to the feature class
@RaananW Done! |
b672bc2
to
de319bd
Compare
de319bd
to
a574589
Compare
Thanks! this is great. I guess we can add a proxy from the teleportation to the camera's observable and mark it deprecated on the camera. But this is a very low priority. |
@RaananW that would be great. It crossed my mind to do that but I am focusing on other improvements currently, like adding a BVH file loader. |
Add observables
onBeforeCameraTeleportRotation
andonAfterCameraTeleportRotation
toWebXRMotionControllerTeleportation
.