Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thin instances: Change default value for the staticBuffer parameter #14679

Merged
merged 2 commits into from Jan 8, 2024

Conversation

Popov72
Copy link
Contributor

@Popov72 Popov72 commented Jan 6, 2024

See https://forum.babylonjs.com/t/mesh-with-thin-instance-slower-than-with-full-vertices/46756/7

When staticBuffer = false, Angle (in DirectX mode only - OpenGL is fine) can rearrange the buffers under the hood and completely break performance...

So, even if it's a breaking change, it's probably best to have it true by default...

@bjsplat
Copy link
Collaborator

bjsplat commented Jan 6, 2024

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Jan 6, 2024

@bjsplat
Copy link
Collaborator

bjsplat commented Jan 6, 2024

Visualization tests for webgl2 have failed. If some tests failed because the snapshots do not match, the report can be found at

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/14679/merge/testResults/webgl2/index.html

If tests were successful afterwards, this report might not be available anymore.

@sebavan sebavan merged commit ff165b7 into master Jan 8, 2024
10 checks passed
@sebavan sebavan deleted the Popov72-patch-4 branch January 8, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants