Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RSM: add support for reflective shadow maps generation + GI based on RSM #14680

Merged
merged 4 commits into from
Jan 8, 2024

Conversation

Popov72
Copy link
Contributor

@Popov72 Popov72 commented Jan 7, 2024

I wasn't sure where to add the files / how to name them (as well as the classes)...
Please let me know if I need to change anything in this regard.

@bjsplat
Copy link
Collaborator

bjsplat commented Jan 7, 2024

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Jan 7, 2024

Copy link
Member

@sebavan sebavan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks amazing to me :-)

Could you add the reference you found in the shaders and the main class so that if we need to refer to it later on it is easier to find the technique details ?

Should we update the DOF kernel blur by the bilateral one here or the opposite ? It looks like we have two shaders with the same intent ?

@Popov72 Popov72 enabled auto-merge January 8, 2024 18:17
@Popov72 Popov72 merged commit b6f0a94 into BabylonJS:master Jan 8, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants