Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add canvas option for VideoRecorder #14707

Merged
merged 1 commit into from
Jan 15, 2024

Conversation

SalmaBesbes
Copy link
Contributor

by default VideoRecoder records the rendering canvas we get from the engine, this optional prop will be useful in case we have multiple canvases

@bjsplat
Copy link
Collaborator

bjsplat commented Jan 15, 2024

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Jan 15, 2024

@sebavan sebavan merged commit a2e081f into BabylonJS:master Jan 15, 2024
11 checks passed
@SalmaBesbes SalmaBesbes deleted the video-recorder-canvas branch January 16, 2024 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants