Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add typedoc missing comments #14717

Merged
merged 3 commits into from
Jan 18, 2024
Merged

Conversation

carolhmj
Copy link
Contributor

This PR adds missing comments detected by our typedoc script. It also marks the method ReviewUniform in the CustomMaterial class as @internal. And it adds an extra check to the typedoc script to detect some comments that weren't picked up.

@bjsplat
Copy link
Collaborator

bjsplat commented Jan 18, 2024

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Jan 18, 2024

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Jan 18, 2024

@RaananW RaananW merged commit ebe1c08 into BabylonJS:master Jan 18, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants