Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better feature handling #14732

Merged
merged 1 commit into from
Jan 23, 2024
Merged

Better feature handling #14732

merged 1 commit into from
Jan 23, 2024

Conversation

RaananW
Copy link
Member

@RaananW RaananW commented Jan 23, 2024

A feature that is a native WebXR feature will not attach if the session was not enabled with it, or that the session doesn't support it.

In addition, a warning will be shown if the feature was initialized after the session has started.

@bjsplat
Copy link
Collaborator

bjsplat commented Jan 23, 2024

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Jan 23, 2024

@sebavan sebavan merged commit bfb08f2 into BabylonJS:master Jan 23, 2024
11 checks passed
@RaananW RaananW deleted the noAttachNoEnabled branch January 23, 2024 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants