Unity Toolkit Workaround

[MackeyK24]

Workaround to temp disable the Unity Toolkit scripts loading from playground loadScriptAsync. But load from BABYLON.Tools.LoadScriptAsync while debugging the issue

[bjsplat]

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

[bjsplat]

Snapshot stored with reference name:
refs/pull/14754/merge

Test environment:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/14754/merge/index.html

To test a playground add it to the URL, for example:

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/14754/merge/index.html#WGZLGJ#4600

Links to test babylon tools with this snapshot:

https://playground.babylonjs.com/?snapshot=refs/pull/14754/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/14754/merge
https://gui.babylonjs.com/?snapshot=refs/pull/14754/merge
https://nme.babylonjs.com/?snapshot=refs/pull/14754/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/14754/merge#BCU1XR#0

[RaananW]

Instead of merging this, let's find out what is wrong with the loadScript function. Can you reproduce that so I can debug this with you?

[MackeyK24]

Yo @RaananW ...

I found two issues...
The first issue why it didnt quite work right using the _loadScriptAsync but it did work correctly using Tools.LoadScriptAsync is because we are missing text/javascript for the type on the dynamic script tag.
So i added the attribute like so:

    private async _loadScriptAsync(url: string): Promise<void> {
        return new Promise((resolve) => {
            const script = document.createElement("script");
            script.setAttribute("type", "text/javascript");
            script.setAttribute("src", url);
            script.onload = () => {
                resolve();
            };
            document.head.appendChild(script);
        });
    }

The second is that the Tools.LoasScriptAsync which is an async wrapper for the Tools.LoadScript does not pass the scriptID thru to the underlying Tools.LoadScript. So I fixed the Tools.LoadScriptAsync like so:

    public static LoadScriptAsync(scriptUrl: string, scriptId?: string): Promise<void> {
        return new Promise((resolve, reject) => {
            this.LoadScript(
                scriptUrl,
                () => {
                    resolve();
                },
                (message, exception) => {
                    reject(exception || new Error(message));
                },
                scriptId
            );
        });
    }

That should fix things :)

[RaananW]

i'm good with the changes, once you fix the missing docs :-)

[MackeyK24]

What missing docs ?
Are you talking some sort of doc for the commit or are you talking docs in general for the whole toolkit ?

[RaananW]

Just check the files, the error is there. You are missing code doc of one variable

[MackeyK24]

I see now, sorry... Fixed missing param doc