Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NME: Fix preview for some of the pre-defined meshes #14774

Merged
merged 1 commit into from Feb 8, 2024

Conversation

Popov72
Copy link
Contributor

@Popov72 Popov72 commented Feb 8, 2024

See https://forum.babylonjs.com/t/pbr-node-material-with-coarse-roughness-issue-with-non-omni-lights/47812/5

Concerned meshes: sphere, cube, plane

The problem was that we bake the current transformation but don't move the mesh to the top of the hierarchy (`parent=nullhttps://forum.babylonjs.com/t/pbr-node-material-with-coarse-roughness-issue-with-non-omni-lights/47812/5). So, the parent transformation is applied two times, one time during baking and another time when rendering the mesh.

Also, there was a bug in the baking method, because tangents were not transformed.

@Popov72 Popov72 added bug nme Node Material Editor labels Feb 8, 2024
@bjsplat
Copy link
Collaborator

bjsplat commented Feb 8, 2024

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Feb 8, 2024

@bjsplat
Copy link
Collaborator

bjsplat commented Feb 8, 2024

@RaananW
Copy link
Member

RaananW commented Feb 8, 2024

Oh, and please ignore the webgpu test failure (if it is persistent). I made the change and fixed it a fe minutes after, but this PR was submitted before I fixed it...

@RaananW RaananW merged commit 58b5801 into BabylonJS:master Feb 8, 2024
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug nme Node Material Editor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants