Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix camera panning issue when camera is parented #14780

Merged
merged 4 commits into from
Feb 14, 2024

Conversation

2315137135
Copy link
Contributor

@bjsplat
Copy link
Collaborator

bjsplat commented Feb 14, 2024

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Feb 14, 2024

@bjsplat
Copy link
Collaborator

bjsplat commented Feb 14, 2024

Visualization tests for WebGPU (Experimental)
Important - these might fail sporadically. This is an optional test.

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/14780/merge/testResults/webgpuplaywright/index.html

@bjsplat
Copy link
Collaborator

bjsplat commented Feb 14, 2024

@RaananW
Copy link
Member

RaananW commented Feb 14, 2024

Copy link
Member

@RaananW RaananW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! just a small request to not generate new objects.

packages/dev/core/src/Cameras/arcRotateCamera.ts Outdated Show resolved Hide resolved
@RaananW RaananW changed the title fix https://forum.babylonjs.com/t/camera-panning-issue-when-using-par… Fix camera panning issue when camera is parented Feb 14, 2024
@bjsplat
Copy link
Collaborator

bjsplat commented Feb 14, 2024

Visualization tests for WebGPU (Experimental)
Important - these might fail sporadically. This is an optional test.

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/14780/merge/testResults/webgpuplaywright/index.html

@bjsplat
Copy link
Collaborator

bjsplat commented Feb 14, 2024

Visualization tests for WebGPU (Experimental)
Important - these might fail sporadically. This is an optional test.

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/14780/merge/testResults/webgpuplaywright/index.html

@sebavan sebavan merged commit 3037e36 into BabylonJS:master Feb 14, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants