Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added @babylonjs/ktx2decoder public package #14811

Merged
merged 4 commits into from
Mar 5, 2024
Merged

Conversation

RaananW
Copy link
Member

@RaananW RaananW commented Feb 26, 2024

This PR adds a new publich package - @babylonjs/ktx2decoder, which can be used instead of our ktx2decoder on the CDN.

This package will include the compiled wasm files, created by the khronos group. License file(s) and a notice file was added to the package, including the Khronos group and all licenses that were used to create the wasm directory.

Note - the wasm directory will be populated during build.

This PR is directly related to #14773, but both can be merged independently.

@bjsplat
Copy link
Collaborator

bjsplat commented Feb 26, 2024

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Feb 26, 2024

Reviewer - this PR has made changes to one or more package.json files.

@bjsplat
Copy link
Collaborator

bjsplat commented Feb 26, 2024

@bjsplat
Copy link
Collaborator

bjsplat commented Feb 26, 2024

@bjsplat
Copy link
Collaborator

bjsplat commented Feb 26, 2024

Visualization tests for WebGPU (Experimental)
Important - these might fail sporadically. This is an optional test.

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/14811/merge/testResults/webgpuplaywright/index.html

@RaananW
Copy link
Member Author

RaananW commented Feb 26, 2024

Closing for now, this needs a few adjustments.

@RaananW RaananW closed this Feb 26, 2024
@RaananW
Copy link
Member Author

RaananW commented Mar 4, 2024

Updated notice file

@RaananW RaananW reopened this Mar 4, 2024
@bjsplat
Copy link
Collaborator

bjsplat commented Mar 4, 2024

Reviewer - this PR has made changes to one or more package.json files.

@RaananW RaananW merged commit 333423b into BabylonJS:master Mar 5, 2024
11 checks passed
@RaananW RaananW deleted the es6ktx2 branch March 5, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants