Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TargetCamera: Add Node Constructor code for TargetCamera #14827

Merged
merged 1 commit into from Mar 4, 2024

Conversation

PolygonalSun
Copy link
Contributor

This PR contains a simple fix for an issue found in a forum post. When a .babylon file is created with a TargetCamera and reimported, the camera will imported using the default behavior (creating a UniversalCamera). The fix here is to add a NodeConstructor to handle instances of TargetCameras

@bjsplat
Copy link
Collaborator

bjsplat commented Mar 1, 2024

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Mar 1, 2024

@bjsplat
Copy link
Collaborator

bjsplat commented Mar 1, 2024

Visualization tests for WebGPU (Experimental)
Important - these might fail sporadically. This is an optional test.

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/14827/merge/testResults/webgpuplaywright/index.html

@bjsplat
Copy link
Collaborator

bjsplat commented Mar 1, 2024

@RaananW RaananW enabled auto-merge March 4, 2024 12:10
@RaananW RaananW merged commit f717362 into BabylonJS:master Mar 4, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants