New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PBR: fix the "eho" debug mode #14910

Merged

sebavan merged 2 commits into BabylonJS:master from Popov72:master

Mar 26, 2024

Contributor

Popov72 commented Mar 26, 2024

See https://forum.babylonjs.com/t/edgerendering-not-apply-animation/49026/9

Popov72 and others added 2 commits

March 26, 2024 11:14


          Fixed Tensor value typing (BabylonJS#14876)

716882a

* Fixed types of Tensor.FromArray and Tensor.FromArrayToRef

* Fixed types

* Fixed ThinEngine.setMatrices type
Updated Tensor types

* Removed uneeded DeepImmutable in FromArray and FromArrayToRef

* Added new TensorValue
Removed TensorValueElement and TensorElement
Changed FlattenArray to handle recursive arrays
Renamed TensorValue to ValueOfTensor

* Added a newline

* Update packages/dev/core/src/Engines/Native/nativeDataStream.ts

* Update packages/dev/core/src/Engines/Native/nativeDataStream.ts

---------

Co-authored-by: Raanan Weber <raananw+github@gmail.com>


          Merge branch 'master' of https://github.com/Popov72/Babylon.js

73728b5

Popov72 added bug materials labels

Collaborator

bjsplat commented Mar 26, 2024

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

sebavan approved these changes

View reviewed changes

sebavan enabled auto-merge

March 26, 2024 10:23

Collaborator

bjsplat commented Mar 26, 2024

Snapshot stored with reference name:
refs/pull/14910/merge

Test environment:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/14910/merge/index.html

To test a playground add it to the URL, for example:

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/14910/merge/index.html#WGZLGJ#4600

Links to test babylon tools with this snapshot:

https://playground.babylonjs.com/?snapshot=refs/pull/14910/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/14910/merge
https://gui.babylonjs.com/?snapshot=refs/pull/14910/merge
https://nme.babylonjs.com/?snapshot=refs/pull/14910/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/14910/merge#BCU1XR#0

Collaborator

bjsplat commented Mar 26, 2024

WebGL2 visualization test reporter:

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/14910/merge/testResults/webgl2playwright/index.html

Collaborator

bjsplat commented Mar 26, 2024

Visualization tests for WebGPU (Experimental)
Important - these might fail sporadically. This is an optional test.

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/14910/merge/testResults/webgpuplaywright/index.html

sebavan merged commit 732f023 into BabylonJS:master

11 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment