Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add actualBoundingBoxAscent and actualBoundingBoxDescent props to ITextMetrics #14913

Merged
merged 1 commit into from Mar 27, 2024

Conversation

yedpodtrzitko
Copy link
Contributor

Hi,
these mentioned properties were discussed in the following forum thread. The thread was marked as resolved with info the props will be added, but it looks like it has never happened.

https://forum.babylonjs.com/t/upgrading-to-the-latest-babylon-5-2-0/29377/1

@bjsplat
Copy link
Collaborator

bjsplat commented Mar 27, 2024

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Mar 27, 2024

@bjsplat
Copy link
Collaborator

bjsplat commented Mar 27, 2024

@bjsplat
Copy link
Collaborator

bjsplat commented Mar 27, 2024

Visualization tests for WebGPU (Experimental)
Important - these might fail sporadically. This is an optional test.

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/14913/merge/testResults/webgpuplaywright/index.html

@RaananW
Copy link
Member

RaananW commented Mar 27, 2024

Asking @CedricGuillemet for a review here

@RaananW RaananW merged commit eaaf52e into BabylonJS:master Mar 27, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants