Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove render count from some visual tests #14948

Merged
merged 2 commits into from Apr 5, 2024

Conversation

bghgary
Copy link
Contributor

@bghgary bghgary commented Apr 4, 2024

This is not strictly necessary for the web side of things, but it is causing an issue for native, so I'm making them consistent.

@bghgary bghgary requested a review from docEdub April 4, 2024 23:33
@bjsplat
Copy link
Collaborator

bjsplat commented Apr 4, 2024

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 4, 2024

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 4, 2024

@bghgary bghgary changed the title Remove render count from scissor tests Remove render count from some visual tests Apr 4, 2024
@bjsplat
Copy link
Collaborator

bjsplat commented Apr 5, 2024

Visualization tests for WebGPU (Experimental)
Important - these might fail sporadically. This is an optional test.

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/14948/merge/testResults/webgpuplaywright/index.html

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 5, 2024

Visualization tests for WebGL 1 have failed. If some tests failed because the snapshots do not match, the report can be found at

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/14948/merge/testResults/webgl1/index.html

If tests were successful afterwards, this report might not be available anymore.

@bghgary bghgary marked this pull request as ready for review April 5, 2024 15:39
@bghgary bghgary merged commit 56ae711 into BabylonJS:master Apr 5, 2024
11 checks passed
@bghgary bghgary deleted the scissor-test-fix branch April 5, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants