Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ComputeEffect: Implement onError callback #14952

Merged
merged 1 commit into from Apr 8, 2024

Conversation

Popov72
Copy link
Contributor

@Popov72 Popov72 commented Apr 8, 2024

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 8, 2024

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 8, 2024

Copy link
Contributor

@stefnotch stefnotch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to also provide the offset and length fields of the compile error messages?

Also, I just realised that if Babylon.js modifies the WGSL code, then the line number would be something unexpected that I couldn't easily map back.

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 8, 2024

Visualization tests for WebGPU (Experimental)
Important - these might fail sporadically. This is an optional test.

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/14952/merge/testResults/webgpuplaywright/index.html

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 8, 2024

Visualization tests for WebGL 1 have failed. If some tests failed because the snapshots do not match, the report can be found at

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/14952/merge/testResults/webgl1/index.html

If tests were successful afterwards, this report might not be available anymore.

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 8, 2024

@RaananW RaananW merged commit c5c9b06 into BabylonJS:master Apr 8, 2024
11 checks passed
@Popov72
Copy link
Contributor Author

Popov72 commented Apr 8, 2024

@stefnotch See #14955

RaananW pushed a commit that referenced this pull request Apr 8, 2024
* Implement compute effect onError callback

* Add offset and length
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants