Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Matrix.multiplyByFloats and Vector3.Project in WebGPU #14954

Merged
merged 2 commits into from Apr 8, 2024

Conversation

Popov72
Copy link
Contributor

@Popov72 Popov72 commented Apr 8, 2024

See https://forum.babylonjs.com/t/why-matrix-multiplyinplace-is-not-bxa/49400

I also fixed the Vector3.Project method in WebGPU (when NDC range is 0..1 instead of -1..1).

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 8, 2024

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 8, 2024

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 8, 2024

Visualization tests for WebGPU (Experimental)
Important - these might fail sporadically. This is an optional test.

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/14954/merge/testResults/webgpuplaywright/index.html

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 8, 2024

Visualization tests for WebGL 1 have failed. If some tests failed because the snapshots do not match, the report can be found at

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/14954/merge/testResults/webgl1/index.html

If tests were successful afterwards, this report might not be available anymore.

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 8, 2024

@Popov72 Popov72 changed the title Matrix: Fix multiplyByFloats and improve doc Fix Matrix.multiplyByFloats and Project in WebGPU Apr 8, 2024
@Popov72 Popov72 changed the title Fix Matrix.multiplyByFloats and Project in WebGPU Fix Matrix.multiplyByFloats and Vector3.Project in WebGPU Apr 8, 2024
@bjsplat
Copy link
Collaborator

bjsplat commented Apr 8, 2024

Visualization tests for WebGPU (Experimental)
Important - these might fail sporadically. This is an optional test.

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/14954/merge/testResults/webgpuplaywright/index.html

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 8, 2024

Visualization tests for WebGL 1 have failed. If some tests failed because the snapshots do not match, the report can be found at

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/14954/merge/testResults/webgl1/index.html

If tests were successful afterwards, this report might not be available anymore.

@RaananW RaananW merged commit 08879ff into BabylonJS:master Apr 8, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants