Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix visualization tests #14956

Merged
merged 2 commits into from Apr 8, 2024
Merged

Conversation

RaananW
Copy link
Member

@RaananW RaananW commented Apr 8, 2024

Two issues I found with newly added tests:

glTF Clear Coat:

In config.json gl are lower case. this works in windows, but fails on linux (which is the reason webgl1 and webgpu tests fail).

Render To 3D RT - snapshot was missing.

If you wonder why it worked in WebGL2 - the WebGL2 tests were set to run twice in case the first time fails. When playwright doesn't find a snapshot it generates it. So - WebGL2 failed the first time because of missing snapshots, and then generated it and re-ran the tests.

This was corrected!

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 8, 2024

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 8, 2024

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 8, 2024

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 8, 2024

Visualization tests for WebGPU (Experimental)
Important - these might fail sporadically. This is an optional test.

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/14956/merge/testResults/webgpuplaywright/index.html

@RaananW RaananW enabled auto-merge (squash) April 8, 2024 14:10
@RaananW RaananW merged commit 3b0a7e5 into BabylonJS:master Apr 8, 2024
11 checks passed
@RaananW RaananW deleted the fixGLTFClearCoatFilename branch April 8, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants