Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix comment for getHighestFrame #14975

Merged
merged 2 commits into from Apr 11, 2024
Merged

Conversation

wy-luke
Copy link
Contributor

@wy-luke wy-luke commented Apr 11, 2024

I assume that the result of getHighestFrame() should be the frame, rather the frame rate.

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 11, 2024

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 11, 2024

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 11, 2024

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 11, 2024

Visualization tests for WebGPU (Experimental)
Important - these might fail sporadically. This is an optional test.

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/14975/merge/testResults/webgpuplaywright/index.html

@sebavan sebavan merged commit 4b0dc4e into BabylonJS:master Apr 11, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants