BoneLookController: Fix bone scaling being lost

[Popov72]

See https://forum.babylonjs.com/t/why-is-bone-scale-resetting-during-bonelookcontroller-update/49667

This PR fixes the problem, HOWEVER I don't understand where in the calculation in BoneLookController or in Bone the bone scaling is lost.... It would be better to understand, to be sure it's the right fix...

[bjsplat]

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

[bjsplat]

Snapshot stored with reference name:
refs/pull/14987/merge

Test environment:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/14987/merge/index.html

To test a playground add it to the URL, for example:

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/14987/merge/index.html#WGZLGJ#4600

Links to test babylon tools with this snapshot:

https://playground.babylonjs.com/?snapshot=refs/pull/14987/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/14987/merge
https://gui.babylonjs.com/?snapshot=refs/pull/14987/merge
https://nme.babylonjs.com/?snapshot=refs/pull/14987/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/14987/merge#BCU1XR#0

[bjsplat]

Visualization tests for WebGPU (Experimental)
Important - these might fail sporadically. This is an optional test.

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/14987/merge/testResults/webgpuplaywright/index.html

[bjsplat]

WebGL2 visualization test reporter:

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/14987/merge/testResults/webgl2playwright/index.html

[CedricGuillemet]

I'm not surprised to see scaling lost somewhere because of matrix decompose/recompose.

[RaananW]

I am merging this. @Popov72 , @CedricGuillemet - do we want to open an issue to track the question in the description? Or is this the accepted solution?

[CedricGuillemet]

Let's see if @bghgary has some recommendation. For me, it's an acceptable fix.

[RaananW]

Might be the culprit? - https://github.com/BabylonJS/Babylon.js/blob/master/packages/dev/core/src/Bones/bone.ts#L438

I'll wait for @bghgary to merge this.

[bjsplat]

Visualization tests for WebGPU (Experimental)
Important - these might fail sporadically. This is an optional test.

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/14987/merge/testResults/webgpuplaywright/index.html

[Popov72]

Might be the culprit? - https://github.com/BabylonJS/Babylon.js/blob/master/packages/dev/core/src/Bones/bone.ts#L438

The decompose gets the scaling, so that should be ok.