Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting a static worker pool in the ktx2container instead of passing it in the constructor #14991

Merged
merged 1 commit into from Apr 17, 2024

Conversation

RaananW
Copy link
Member

@RaananW RaananW commented Apr 16, 2024

This will allow using the @babylonjs/ktx2decoder package when using ktx2 in glTF without first constructing the class.

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 16, 2024

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 16, 2024

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 16, 2024

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 16, 2024

Visualization tests for WebGPU (Experimental)
Important - these might fail sporadically. This is an optional test.

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/14991/merge/testResults/webgpuplaywright/index.html

@sebavan sebavan merged commit 5b1c4bf into BabylonJS:master Apr 17, 2024
11 checks passed
@RaananW RaananW deleted the ktx2decoderWorkerPoolInGLTF branch April 17, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants