Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix memory leak in MeshoptCompression #14995

Merged
merged 1 commit into from Apr 17, 2024
Merged

Conversation

OrigamiDev-Pete
Copy link

As discussed in https://forum.babylonjs.com/t/meshoptdecoder-memory-leak/49696

By using web workers to decode the buffer we can terminate the web worker which releases the wasm heap. In the future, memory.discard may be a better way of solving this, but this API is not available yet.

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 16, 2024

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 17, 2024

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 17, 2024

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 17, 2024

Visualization tests for WebGPU (Experimental)
Important - these might fail sporadically. This is an optional test.

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/14995/merge/testResults/webgpuplaywright/index.html

@sebavan sebavan requested a review from bghgary April 17, 2024 00:43
Copy link
Member

@RaananW RaananW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting for @bghgary for a final approval

Copy link
Contributor

@bghgary bghgary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sebavan sebavan merged commit ef6babf into BabylonJS:master Apr 17, 2024
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants