Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing audio init #14997

Merged
merged 1 commit into from
Apr 17, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/dev/core/src/Audio/audioEngine.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,12 @@ import type { Analyser } from "./analyser";
import type { Nullable } from "../types";
import { Observable } from "../Misc/observable";
import { Logger } from "../Misc/logger";
import { Engine } from "../Engines/engine";
import { AbstractEngine } from "../Engines/abstractEngine";
import type { IAudioEngine } from "./Interfaces/IAudioEngine";
import { IsWindowObjectExist } from "../Misc/domManagement";

// Sets the default audio engine to Babylon.js
Engine.AudioEngineFactory = (
AbstractEngine.AudioEngineFactory = (
hostElement: Nullable<HTMLElement>,
audioContext: Nullable<AudioContext>,
audioDestination: Nullable<AudioDestinationNode | MediaStreamAudioDestinationNode>
Expand Down
4 changes: 2 additions & 2 deletions packages/dev/core/src/Engines/abstractEngine.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1993,14 +1993,14 @@ export abstract class AbstractEngine {
*/
// Not mixed with Version for tooling purpose.
public static get NpmPackage(): string {
return "babylonjs@7.0.0";
return "babylonjs@7.2.2";
}

/**
* Returns the current version of the framework
*/
public static get Version(): string {
return "7.0.0";
return "7.2.2";
}

/**
Expand Down
1 change: 1 addition & 0 deletions packages/dev/core/src/Engines/engine.ts
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ import {
_CommonInit,
} from "./engine.common";
import { PerfCounter } from "../Misc/perfCounter";
import "../Audio/audioEngine";

/**
* The engine class is responsible for interfacing with all lower-level APIs such as WebGL and Audio
Expand Down
1 change: 1 addition & 0 deletions packages/dev/core/src/Engines/webgpuEngine.ts
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,7 @@ import "./AbstractEngine/abstractEngine.loadingScreen";
import "./AbstractEngine/abstractEngine.dom";
import "./AbstractEngine/abstractEngine.states";
import "./AbstractEngine/abstractEngine.renderPass";
import "../Audio/audioEngine";

const viewDescriptorSwapChainAntialiasing: GPUTextureViewDescriptor = {
label: `TextureView_SwapChain_ResolveTarget`,
Expand Down