Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Quaternion and slerp for alpha/beta/gamma arcrotate interpolation #15254

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

CedricGuillemet
Copy link
Contributor

@CedricGuillemet CedricGuillemet commented Jul 8, 2024

Using modulo and Euler angles is always a bad idea. Using quaternion and slerp instead.

test PG : #TT1T4C#2

@bjsplat
Copy link
Collaborator

bjsplat commented Jul 8, 2024

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Jul 8, 2024

@bjsplat
Copy link
Collaborator

bjsplat commented Jul 8, 2024

@bjsplat
Copy link
Collaborator

bjsplat commented Jul 8, 2024

@RaananW
Copy link
Member

RaananW commented Jul 8, 2024

Is this a breaking change to the camera behavior?

@CedricGuillemet
Copy link
Contributor Author

Is this a breaking change to the camera behavior?

Nop, it's a math improvement for this feature: https://github.com/BabylonJS/Babylon.js/pull/15248/files

@RaananW RaananW merged commit 2f04248 into BabylonJS:master Jul 8, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants