Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make CleanUrl effective in fileTools.ts #15258

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

chubei-urus
Copy link
Contributor

Hi looks like there was a bug in fileTools.ts, where the cleaned URL is not passed to PreprocessUrl.

@bjsplat
Copy link
Collaborator

bjsplat commented Jul 9, 2024

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Jul 9, 2024

Copy link
Member

@RaananW RaananW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, good catch :-)

@RaananW RaananW enabled auto-merge (squash) July 9, 2024 10:44
@chubei-urus
Copy link
Contributor Author

Thanks for the quick merge! May I ask when the next release will be?

@bjsplat
Copy link
Collaborator

bjsplat commented Jul 9, 2024

@bjsplat
Copy link
Collaborator

bjsplat commented Jul 9, 2024

@RaananW RaananW merged commit e3b9abf into BabylonJS:master Jul 9, 2024
10 of 12 checks passed
@chubei-urus chubei-urus deleted the patch-2 branch July 9, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants