Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build test #5381

Merged
merged 2 commits into from Oct 17, 2018
Merged

Build test #5381

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ea30112
Intro text for build error
sebavan Oct 17, 2018
8c16bdb
Fix Build
sebavan Oct 17, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
30 changes: 14 additions & 16 deletions Tools/Gulp/gulpfile.js
View file
Open in desktop
Expand Up @@ -355,15 +355,13 @@ gulp.task("typescript-compile", function() {
summarizeFailureOutput: true
}));

//If this gulp task is running on travis, file the build!
if (process.env.TRAVIS) {
tsResult.once("error", function() {
tsResult.once("finish", function() {
console.log("Typescript compile failed");
process.exit(1);
});
tsResult.once("error", function(err) {
tsResult.once("finish", function() {
console.log("Typescript compile failed");
console.error(err);
process.exit(1);
});
}
});

return merge2([
tsResult.dts
Expand Down Expand Up @@ -891,14 +889,13 @@ gulp.task("modules-compile", function() {
.pipe(tsProject());

// If this gulp task is running on travis
if (process.env.TRAVIS) {
tsResult.once("error", function() {
tsResult.once("finish", function() {
console.log("Typescript compile failed");
process.exit(1);
});
tsResult.once("error", function(err) {
tsResult.once("finish", function() {
console.log("Typescript compile failed");
console.error(err);
process.exit(1);
});
}
});

return merge2([
tsResult.dts
Expand Down Expand Up @@ -1205,8 +1202,9 @@ gulp.task("tests-unit-transpile", function(done) {
.pipe(tsProject());

tsResult.once("error", function() {
tsResult.once("finish", function() {
tsResult.once("finish", function(err) {
console.log("Typescript compile failed");
console.error(err);
process.exit(1);
});
});
Expand Down
2 changes: 1 addition & 1 deletion src/Cameras/XR/babylon.webXRInput.ts
View file
Open in desktop
Expand Up @@ -49,7 +49,7 @@ module BABYLON {
public constructor(private helper: WebXRExperienceHelper) {
this._frameObserver = helper._sessionManager.onXRFrameObservable.add(() => {
if (!helper._sessionManager._currentXRFrame || !helper._sessionManager._currentXRFrame.getDevicePose) {
return false;
return;
}

var xrFrame = helper._sessionManager._currentXRFrame;
Expand Down