Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NME: Fix code generated for the gradient block #9489

Merged
merged 2 commits into from Nov 26, 2020
Merged

NME: Fix code generated for the gradient block #9489

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
967af91
Fix code generated for the gradient block
Popov72 Nov 26, 2020
79c3d81
Merge branch 'master' into fix-nme-gradientcolor-code
sebavan Nov 26, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions dist/preview release/what's new.md
View file
Open in desktop
Expand Up @@ -45,6 +45,7 @@
- Fix an issue with keyboard control (re)attachment. ([#9411](https://github.com/BabylonJS/Babylon.js/issues/9411)) ([RaananW](https://github.com/RaananW))
- Fix issue where PBRSpecularGlossiness materials were excluded from export [#9423](https://github.com/BabylonJS/Babylon.js/issues/9423)([Drigax](https://github.com/drigax))
- Fix direct loading of a glTF string that has base64-encoded URI. ([bghgary](https://github.com/bghgary))
- Fix the code generated for the NME gradient block ([Popov72](https://github.com/Popov72))
- Fix ssao2RenderingPipeline for orthographic cameras ([Kesshi](https://github.com/Kesshi))

## Breaking changes
Expand Down
2 changes: 2 additions & 0 deletions src/Materials/Node/Blocks/gradientBlock.ts
View file
Open in desktop
Expand Up @@ -183,6 +183,8 @@ export class GradientBlock extends NodeMaterialBlock {
protected _dumpPropertiesCode() {
var codeString = "";

codeString += `${this._codeVariableName}.colorSteps = [];\r\n`;

for (var colorStep of this.colorSteps) {
codeString += `${this._codeVariableName}.colorSteps.push(new BABYLON.GradientBlockColorStep(${colorStep.step}, new BABYLON.Color3(${colorStep.color.r}, ${colorStep.color.g}, ${colorStep.color.b})));\r\n`;
}
Expand Down