Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Canvas] Color parsing #1001

Closed
CedricGuillemet opened this issue Feb 15, 2022 · 0 comments · Fixed by #1051
Closed

[Canvas] Color parsing #1001

CedricGuillemet opened this issue Feb 15, 2022 · 0 comments · Fixed by #1051

Comments

@CedricGuillemet
Copy link
Contributor

rgba(r,g,b,a) parsing not supported by regex.
Also reorder code so regex is used last for better performance.
Bonus point: check parsing in test unit.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Canvas] Color parsing improvements CedricGuillemet/BabylonNative
1 participant
@CedricGuillemet