Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for shutting down during async operations #1141

Open
wants to merge 25 commits into
base: master
Choose a base branch
from
Open

Fixes for shutting down during async operations #1141

wants to merge 25 commits into from

Commits on Sep 29, 2022

  1. WIP: Fixes for shutting down during async operations

    @bghgary
    bghgary committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    43dce92 View commit details
    Browse the repository at this point in the history

  2. Change to explicitly call Rundown

    @bghgary
    bghgary committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    925d243 View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2022

  1. Cannot throw in destructors

    @bghgary
    bghgary committed Sep 30, 2022
    Configuration menu
    Copy the full SHA
    c999153 View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2022

  1. Merge remote-tracking branch 'origin/master' into async-fixes

    @bghgary
    bghgary committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    204efb9 View commit details
    Browse the repository at this point in the history

  2. Fix merge issues

    @bghgary
    bghgary committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    9d1e098 View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2022

  1. Merge with new timeout code with work queue fixes

    @bghgary
    bghgary committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    124def4 View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2022

  1. Fix Canvas

    @bghgary
    bghgary committed Oct 28, 2022
    Configuration menu
    Copy the full SHA
    309c4d9 View commit details
    Browse the repository at this point in the history

  2. Fix Android build

    @bghgary
    bghgary committed Oct 28, 2022
    Configuration menu
    Copy the full SHA
    ad88d30 View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2023

  1. Merge remote-tracking branch 'origin/master' into async-fixes

    @bghgary
    bghgary committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    11ca510 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'async-fixes' of https://github.com/bghgary/BabylonNative … 

    …into async-fixes
    @bghgary
    bghgary committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    31248b6 View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2023

  1. Update arcana.cpp

    @bghgary
    bghgary committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    9322360 View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2023

  1. Temp fixes for MediaStream

    @bghgary
    bghgary committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    b4a3c73 View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2023

  1. Add missing std::forward calls for perfect forwarding 

    If the shared_ptr is copied, the final release may end up on a different thread. Adding std::forward will ensure that the lambda is moved and not copied which will prevent multiple threads from owning the shared_ptr. The shared_ptr is being used as a hack anyways. The correct fix is to not use shared_ptr and make Dispatch use the Dispatchable class from AppRuntime or if we can use C++23 someday, use std::move_only_function.
    @bghgary
    bghgary committed Apr 19, 2023
    Configuration menu
    Copy the full SHA
    9305ca8 View commit details
    Browse the repository at this point in the history

Commits on Apr 28, 2023

  1. Work queue shutdown fixes

    @bghgary
    bghgary committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    df246e2 View commit details
    Browse the repository at this point in the history

  2. Miscellaneous Windows AppRuntime fixes

    @bghgary
    bghgary committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    7350715 View commit details
    Browse the repository at this point in the history

  3. Fix typo in AppRuntime for Win32

    @bghgary
    bghgary committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    77dc8f3 View commit details
    Browse the repository at this point in the history

Commits on May 2, 2023

  1. Better fix for work queue shutdown issue

    @bghgary
    bghgary committed May 2, 2023
    Configuration menu
    Copy the full SHA
    def047c View commit details
    Browse the repository at this point in the history

Commits on May 4, 2023

  1. Merge remote-tracking branch 'origin/master' into async-fixes

    @bghgary
    bghgary committed May 4, 2023
    Configuration menu
    Copy the full SHA
    bdaf1b9 View commit details
    Browse the repository at this point in the history

  2. Fix build issues from merge

    @bghgary
    bghgary committed May 4, 2023
    Configuration menu
    Copy the full SHA
    0ae6cf4 View commit details
    Browse the repository at this point in the history

Commits on May 9, 2023

  1. Update arcana.cpp to include continuation fix

    @bghgary
    bghgary committed May 9, 2023
    Configuration menu
    Copy the full SHA
    71efaf4 View commit details
    Browse the repository at this point in the history

  2. Minor style fixes

    @bghgary
    bghgary committed May 9, 2023
    Configuration menu
    Copy the full SHA
    a0db419 View commit details
    Browse the repository at this point in the history

  3. Update comment

    @bghgary
    bghgary committed May 9, 2023
    Configuration menu
    Copy the full SHA
    6909f55 View commit details
    Browse the repository at this point in the history

  4. Update comment 2

    @bghgary
    bghgary committed May 9, 2023
    Configuration menu
    Copy the full SHA
    e9d229d View commit details
    Browse the repository at this point in the history

  5. More style fixes

    @bghgary
    bghgary committed May 9, 2023
    Configuration menu
    Copy the full SHA
    423ed5e View commit details
    Browse the repository at this point in the history

Commits on May 24, 2023

  1. Merge AppRuntime and WorkQueue to fix race condition

    @bghgary
    bghgary committed May 24, 2023
    Configuration menu
    Copy the full SHA
    36a4661 View commit details
    Browse the repository at this point in the history