Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix URL processing code #1180

Merged
merged 5 commits into from Jan 5, 2023
Merged

Fix URL processing code #1180

merged 5 commits into from Jan 5, 2023

Conversation

bghgary
Copy link
Contributor

@bghgary bghgary commented Dec 20, 2022

Fixes #1164
Fixes #1156

Copy link
Contributor

@SergioRZMasson SergioRZMasson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BabylonJS BabylonJS deleted a comment from gitguardian bot Dec 20, 2022
- Update Linux to use latest Clang/GCC compilers
- Use JavaScriptCore instead of V8 to work around BabylonJS#1190
@gitguardian
Copy link

gitguardian bot commented Jan 5, 2023

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
Once a secret has been leaked into a git repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@bghgary bghgary marked this pull request as ready for review January 5, 2023 17:47
@bghgary bghgary enabled auto-merge (squash) January 5, 2023 18:09
@bghgary bghgary merged commit 7eae0c3 into BabylonJS:master Jan 5, 2023
@bghgary bghgary deleted the url-fix branch January 5, 2023 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

URL Processing Bug Curl transfers not completing
2 participants